chore: update eslint-plugin-eui to 0.1.1#210082
Merged
weronikaolejniczak merged 7 commits intoelastic:mainfrom Apr 2, 2025
Merged
chore: update eslint-plugin-eui to 0.1.1#210082weronikaolejniczak merged 7 commits intoelastic:mainfrom
weronikaolejniczak merged 7 commits intoelastic:mainfrom
Conversation
weronikaolejniczak
changed the title
weronikaolejniczak
force-pushed
the
chore/eui-eslint-plugin
branch
2 times, most recently
from
62fc504 to
b0e895a
Compare
weronikaolejniczak
force-pushed
the
chore/eui-eslint-plugin
branch
2 times, most recently
from
d06195f to
25e504b
Compare
weronikaolejniczak
added
release_note:skip
weronikaolejniczak
force-pushed
the
chore/eui-eslint-plugin
branch
from
85dd123 to
ae75b43
Compare
jbudz
approved these changes
Mar 31, 2025
3 tasks
Contributor
Author
|
I have a PR open (elastic/eui#8524) with the fix for:
I will release a patch version and update this PR. EDIT: Done on 347a4e5 |
weronikaolejniczak
force-pushed
the
chore/eui-eslint-plugin
branch
from
e4cb634 to
347a4e5
Compare
weronikaolejniczak
changed the title
Contributor
💔 Build Failed
Failed CI StepsHistory
|
eokoneyo
approved these changes
Apr 2, 2025
Contributor
eokoneyo
left a comment
eokoneyo
left a comment
There was a problem hiding this comment.
Tested locally,
configured rules work;
-
eslint rule, no restricted eui imports works
-
eslint rule no css color works;
-
eslint rule prefer css prop works;
Contributor
Author
|
@elastic/security-generative-ai could you take a look? I only changed the eslint-disable comments in your source 😄 |
patrykkopycinski
approved these changes
Apr 2, 2025
Contributor
|
🚢 @weronikaolejniczak :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bring in the changes from elastic/eui#8304, specifically ESLint rules:
no-restricted-eui-importsno-css-color(migrated from@kbn/eslint-plugin-css)prefer-css-attribute-for-eui-components(migrated from@kbn/eslint-plugin-css)Relates to elastic/eui#8201, https://github.com/elastic/eui-private/issues/275
QA
Instructions
gh pr checkout 210082.yarn kbn bootstrap.Test cases
no-restricted-eui-importsExample files:
src/platform/packages/shared/kbn-ui-theme/src/theme.ts@kbn/ui-theme:src/platform/plugins/private/vis_types/vega/public/data_model/utils.tsno-css-colorExample file:
src/platform/plugins/shared/kibana_react/public/page_template/no_data_page/no_data_card/elastic_agent_card.tsx:50prefer-css-attribute-for-eui-componentsExample file:
x-pack/examples/alerting_example/public/alert_types/always_firing.tsx:166